Skip to content

feat(site): add refresh button on health page #10719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Nov 15, 2023

Fixes #8969

image

@johnstcn johnstcn self-assigned this Nov 15, 2023
@johnstcn johnstcn force-pushed the cj/healthcheck-force-recheck-ui branch 2 times, most recently from 4c6a2ba to 3a5932c Compare November 17, 2023 09:10
@johnstcn johnstcn force-pushed the cj/healthcheck-force-recheck-ui branch from 3a5932c to e804f42 Compare November 17, 2023 10:16
@johnstcn johnstcn changed the title [wip] site: add ui element to force hc refresh [wip] site: add refresh button on health page Nov 17, 2023
@johnstcn johnstcn changed the title [wip] site: add refresh button on health page [wip] feat(site): add refresh button on health page Nov 17, 2023
@johnstcn johnstcn changed the title [wip] feat(site): add refresh button on health page feat(site): add refresh button on health page Nov 17, 2023
@johnstcn johnstcn marked this pull request as ready for review November 17, 2023 14:42
@johnstcn
Copy link
Member Author

johnstcn commented Nov 17, 2023

Thanks for your help @BrunoQuaresma ! I tweaked the design of the button a little bit. EDIT: reverted changes and kept it as a primary action button in the header.

@johnstcn johnstcn requested a review from mtojek November 17, 2023 15:13
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@johnstcn johnstcn merged commit befb42b into main Nov 17, 2023
@johnstcn johnstcn deleted the cj/healthcheck-force-recheck-ui branch November 17, 2023 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

healthcheck: allow configuring healthcheck refresh interval
3 participants