Skip to content

fix(site): fix group name validation #10739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix(site): fix group name validation #10739

merged 1 commit into from
Nov 16, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Close #10679

@BrunoQuaresma BrunoQuaresma requested a review from sreya November 16, 2023 19:52
@BrunoQuaresma BrunoQuaresma self-assigned this Nov 16, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Nov 16, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@BrunoQuaresma
Copy link
Collaborator Author

I relaxed the validation based on what we have on the BE and CLI

@BrunoQuaresma BrunoQuaresma merged commit fefe02c into main Nov 16, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-group-name branch November 16, 2023 21:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sreya sreya sreya approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front-end does not support underscores for group names, back-end does
2 participants
@BrunoQuaresma @sreya