fix: stop redirecting DERP and replicasync http requests #10752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
spikecurtis
force-pushed
the
spike/customers-345
branch
2 times, most recently
from
dfa639c to
a1a771a
Compare
coadler
approved these changes
Nov 17, 2023
| slog.F("relay_address", peer.RelayAddress), slog.Error(err)) | ||
| return | ||
| } | ||
| target, err := ra.Parse("/derp") |
There was a problem hiding this comment.
I think /derp/latency-check might be a bit better since it's meant for pinging, rather than just calling /derp incorrectly.
There was a problem hiding this comment.
That's a good idea. Customers often log status codes, so 426 is going to get them wound up over nothing.
spikecurtis
force-pushed
the
spike/customers-345
branch
from
a1a771a to
07262e4
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where setting CODER_REDIRECT_TO_ACCESS_URL breaks use of multiple Coder server replicas for DERP traffic.