chore: remove New----Builder from dbfake function names #10882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
This was referenced Nov 27, 2023
spikecurtis
force-pushed
the
spike/dbfake-provisionerjobresources-builder
branch
from
e8cffce to
3a2b2d4
Compare
spikecurtis
force-pushed
the
spike/dbfake-shorten-names
branch
from
cce9f6e to
c7f1597
Compare
johnstcn
approved these changes
Nov 27, 2023
spikecurtis
force-pushed
the
spike/dbfake-provisionerjobresources-builder
branch
from
3a2b2d4 to
45b3ea3
Compare
spikecurtis
force-pushed
the
spike/dbfake-shorten-names
branch
from
c7f1597 to
d270a5e
Compare
spikecurtis
force-pushed
the
spike/dbfake-provisionerjobresources-builder
branch
from
45b3ea3 to
e2ede48
Compare
Base automatically changed from
spike/dbfake-provisionerjobresources-builder
to
main
November 27, 2023 10:46
spikecurtis
force-pushed
the
spike/dbfake-shorten-names
branch
from
d270a5e to
1623c32
Compare
mafredri
approved these changes
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop "New" and "Builder" from the function names, in favor of the top-level resource created. This shortens tests and gives a nice syntax. Since everything is a builder, the prefix and suffix don't add much value and just make things harder to read.
I've also chosen to leave
Do()as the function to insert into the database. Even though it's a builder pattern, I fear.Build()might be confusing with Workspace Builds. One other idea isInsert()but if we later add dbfake functions that update, this might be inconsistent.