Skip to content

chore: assign site/ to frontend #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022
Merged

chore: assign site/ to frontend #1091

merged 1 commit into from
Apr 19, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 19, 2022

It didn't seem like this was working as we expected. I think it's because we didn't have the / based on these docs.

@jsjoeio jsjoeio requested a review from greyscaled April 19, 2022 18:07
@jsjoeio jsjoeio self-assigned this Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1091 (c0ccfea) into main (6c9c129) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
+ Coverage   66.05%   66.39%   +0.34%     
==========================================
  Files         256      261       +5     
  Lines       15470    15675     +205     
  Branches      152      152              
==========================================
+ Hits        10218    10408     +190     
- Misses       4181     4197      +16     
+ Partials     1071     1070       -1     
Flag Coverage Δ
unittest-go-macos-latest 53.32% <ø> (?)
unittest-go-postgres- 65.62% <ø> (-0.28%) ⬇️
unittest-go-ubuntu-latest 55.81% <ø> (?)
unittest-go-windows-2022 52.91% <ø> (?)
unittest-js 67.58% <ø> (ø)
Impacted Files Coverage Δ
codersdk/provisionerdaemons.go 59.70% <0.00%> (-5.98%) ⬇️
coderd/workspaceagents.go 59.62% <0.00%> (-2.97%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
provisionerd/provisionerd.go 78.23% <0.00%> (-1.77%) ⬇️
coderd/provisionerdaemons.go 59.34% <0.00%> (-1.03%) ⬇️
agent/usershell/usershell_windows.go 83.33% <0.00%> (ø)
pty/pty_windows.go 68.25% <0.00%> (ø)
pty/start_windows.go 66.95% <0.00%> (ø)
agent/usershell/usershell_darwin.go 100.00% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9c129...c0ccfea. Read the comment docs.

@jsjoeio jsjoeio requested a review from a team April 19, 2022 18:19
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsjoeio jsjoeio merged commit db1127d into main Apr 19, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-codeowners branch April 19, 2022 18:30
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants