Skip to content

refactor(coderd/healthcheck): make Warnings an object with { Code, Message } #10950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Nov 30, 2023

Relates to #8965

Follow-up of #10915

This is so the UI doesn't need to do any nasty regex extraction from error messages to get the code.

@johnstcn johnstcn self-assigned this Nov 30, 2023
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring looks good to me, and I like the convenience functions 👍

@johnstcn johnstcn merged commit 0789500 into main Nov 30, 2023
@johnstcn johnstcn deleted the cj/healthcheck-warnings-refactor branch November 30, 2023 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants