fix: parse username/workspace correctly on coder state pull --build #10973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
spikecurtis
force-pushed
the
spike/10884-state-pull
branch
from
5eff582 to
32d6651
Compare
johnstcn
approved these changes
Dec 1, 2023
| if err != nil { | ||
| return err | ||
| } | ||
| build, err = client.WorkspaceBuildByUsernameAndWorkspaceNameAndBuildNumber(inv.Context(), owner, workspace, strconv.FormatInt(buildNumber, 10)) |
There was a problem hiding this comment.
Non-blocking:
I wonder if it would make sense to introduce something like
type WorkspaceName string
type WorkspaceOwner string
and make splitNamedWorkspace return those types?
Comment on lines
+31
to
+36
| r := dbfake.WorkspaceBuild(t, store, database.Workspace{ | ||
| OrganizationID: owner.OrganizationID, | ||
| OwnerID: taUser.ID, | ||
| }). | ||
| Seed(database.WorkspaceBuild{ProvisionerState: wantState}). | ||
| Do() |
| var gotState bytes.Buffer | ||
| inv.Stdout = &gotState | ||
| clitest.SetupConfig(t, templateAdmin, root) | ||
| err := inv.Run() | ||
| require.NoError(t, err) | ||
| require.Equal(t, wantState, bytes.TrimSpace(gotState.Bytes())) | ||
| }) | ||
| t.Run("OtherUserBuild", func(t *testing.T) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10884