Skip to content

fix: disable prefetches for audits table #11040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: disable prefetches for audits table #11040

merged 1 commit into from
Dec 5, 2023

Conversation

Parkreiner
Copy link
Member

Helps close #11016

Changes made

  • Updates usePaginatedQuery to let you turn prefetching off
  • Turns off prefetching for audits table

Issues not resolved just yet

  • No updates to the logic for checking the staleness of data just yet – at least according to the RQ docs, our code should already be doing that. Need to look into whether:
    • There's a bug in RQ (unlikely)
    • We need to change how we have our app query client configured

@Parkreiner Parkreiner self-assigned this Dec 5, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Dec 5, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner merged commit dd1f833 into main Dec 5, 2023
@Parkreiner Parkreiner deleted the mes/pag-fix-1 branch December 5, 2023 13:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit log page makes unncessary API requests
1 participant
@Parkreiner