Skip to content

fix(coderd/debug): update putDeploymentHealthSettings to use 204 instead of 304 if not modified #11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix(coderd/debug): update putDeploymentHealthSettings to use 204 instead of 304 if not modified #11048

merged 1 commit into from
Dec 5, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Dec 5, 2023

No description provided.

@johnstcn johnstcn self-assigned this Dec 5, 2023
@johnstcn johnstcn changed the title fix(coderd/debug): putDeploymentHealthSettings: use 204 instead of 304 if not modified fix(coderd/debug): update putDeploymentHealthSettings to use 204 instead of 304 if not modified Dec 5, 2023
@johnstcn johnstcn merged commit f66e802 into main Dec 5, 2023
@johnstcn johnstcn deleted the cj/put-deployment-health branch December 5, 2023 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
mtojek
mtojek reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-merge approval, thanks for fixing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek left review comments

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @BrunoQuaresma @mtojek