Skip to content

fix(coderd/database): remove column updated_at from provisioner_daemons table #11108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Dec 8, 2023

Relates to #10676

Drops updated_at in favour of last_seen_at.

Should have been part of #11033

We're not inserting provisioner daemons into the database right now anyway so this is pretty safe.

@johnstcn johnstcn self-assigned this Dec 8, 2023
@johnstcn johnstcn changed the title fix(coderd/database): provisioner_daemon.updated_at -> last_seen_at fix(coderd/database): drop provisioner_daemon.updated_at Dec 8, 2023
@johnstcn johnstcn force-pushed the cj/provisionerd-rm-updatedat branch 4 times, most recently from 9f7d9e9 to 57f915d Compare December 11, 2023 00:09
@johnstcn johnstcn changed the title fix(coderd/database): drop provisioner_daemon.updated_at fix(coderd/database): remove provisioner_daemon.updated_at Dec 11, 2023
Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit inline

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@johnstcn johnstcn force-pushed the cj/provisionerd-rm-updatedat branch from 57f915d to d5f2b60 Compare December 12, 2023 08:46
@johnstcn johnstcn changed the title fix(coderd/database): remove provisioner_daemon.updated_at fix(coderd/database): remove column updated_at from provisioner_daemons table Dec 12, 2023
@johnstcn johnstcn force-pushed the cj/provisionerd-rm-updatedat branch from d5f2b60 to 7be86bb Compare December 12, 2023 08:52
@johnstcn johnstcn merged commit b027966 into main Dec 12, 2023
@johnstcn johnstcn deleted the cj/provisionerd-rm-updatedat branch December 12, 2023 11:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants