chore(Makefile): use linter version from dogfood Dockerfile #11147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
approved these changes
Dec 12, 2023
|
Why de we need to install the linter again in Makefile if its already included in the dogfood image? |
|
Not everyone/everything uses dogfood; I believe CI does not. |
|
I agree. One other option could be to run CI using our dogfood container. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mismatch between the version of
golangci-lintwe were using in our dogfood Dockerfile and thelint/goMakefile target.lint/goto use the version of golangci-lint defined indogfood/Dockerfilegolangci-lintto the latest version.