Skip to content

fix: Use target="_blank" to redirect for footer version #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Conversation

kylecarbs
Copy link
Member

This forces it to open in a new tab!

@kylecarbs kylecarbs requested a review from code-asher April 25, 2022 20:59
@kylecarbs kylecarbs requested a review from a team as a code owner April 25, 2022 20:59
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1166 (7eb6a3a) into main (759fa5f) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   66.65%   66.43%   -0.22%     
==========================================
  Files         263      263              
  Lines       16427    16427              
  Branches      156      156              
==========================================
- Hits        10949    10914      -35     
- Misses       4363     4390      +27     
- Partials     1115     1123       +8     
Flag Coverage Δ
unittest-go-macos-latest 53.88% <ø> (-0.01%) ⬇️
unittest-go-postgres- 65.80% <ø> (-0.14%) ⬇️
unittest-go-ubuntu-latest 56.50% <ø> (+0.06%) ⬆️
unittest-go-windows-2022 53.49% <ø> (-0.05%) ⬇️
unittest-js 67.42% <ø> (ø)
Impacted Files Coverage Δ
site/src/components/Footer/Footer.tsx 100.00% <ø> (ø)
coderd/workspaceagents.go 57.85% <0.00%> (-3.93%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
peer/conn.go 80.20% <0.00%> (-3.05%) ⬇️
agent/agent.go 66.30% <0.00%> (-2.20%) ⬇️
provisionerd/provisionerd.go 75.83% <0.00%> (-1.47%) ⬇️
coderd/provisionerdaemons.go 62.79% <0.00%> (+0.50%) ⬆️
provisioner/echo/serve.go 59.20% <0.00%> (+4.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 759fa5f...7eb6a3a. Read the comment docs.

@kylecarbs kylecarbs merged commit 4f7ceeb into main Apr 25, 2022
@kylecarbs kylecarbs deleted the footredirect branch April 25, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants