chore: implement device auth flow for fake idp #11707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Emyrk
force-pushed
the
stevenmasley/fake_device_flow
branch
from
b72cea9 to
da21464
Compare
code-asher
approved these changes
Jan 19, 2024
coderd/coderdtest/oidctest/idp.go
Outdated
Comment on lines
1077
to
1083
| _, _ = fmt.Fprint(rw, url.Values{ | ||
| "device_code": {deviceCode}, | ||
| "user_code": {flow.userInput}, | ||
| "verification_uri": {verifyURL}, | ||
| "expires_in": {strconv.Itoa(int(lifetime.Seconds()))}, | ||
| "interval": {"3"}, | ||
| }) |
There was a problem hiding this comment.
Should this use .Encode()? Otherwise it could be printed as map[device_code:[] ...] or whatever the string representation of url.Values is.
This reverts commit f3ac7d0.
* implement test using fake idp device flow * improve error handling around device code failure
Emyrk
force-pushed
the
stevenmasley/fake_device_flow
branch
from
f88117e to
9bc29db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device Flow faking
Device flow: https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/authorizing-oauth-apps
The fake IDP has been used to test all our oauth flows. I introduced a regression (fixed here #11706) because we were not checking the
Acceptheader for the proper mime type. I could have just implemented that check, but I want to implement this for future testing.Will also implement better error handling to return a better error if this happens again.
Kooha-2024-01-19-11-33-33.mp4