Skip to content

feat: Add GIT_COMMITTER information to agent env vars #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

kylecarbs
Copy link
Member

This makes setting up git a bit simpler, and users
can always override these values!

We'll probably add a way to disable our Git integration
anyways, so these could be part of that.

@kylecarbs kylecarbs requested a review from coadler April 25, 2022 22:45
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1171 (9d76d9d) into main (947e8f9) will decrease coverage by 0.31%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   66.51%   66.20%   -0.32%     
==========================================
  Files         263      263              
  Lines       16573    16613      +40     
  Branches      156      156              
==========================================
- Hits        11024    10998      -26     
- Misses       4419     4470      +51     
- Partials     1130     1145      +15     
Flag Coverage Δ
unittest-go-macos-latest 53.62% <54.54%> (-0.15%) ⬇️
unittest-go-postgres- 65.53% <54.54%> (-0.27%) ⬇️
unittest-go-ubuntu-latest 56.12% <54.54%> (-0.19%) ⬇️
unittest-go-windows-2022 53.20% <54.54%> (-0.10%) ⬇️
unittest-js 67.45% <ø> (ø)
Impacted Files Coverage Δ
codersdk/workspaceagents.go 51.11% <37.50%> (-2.25%) ⬇️
coderd/workspaceagents.go 58.14% <53.44%> (-5.07%) ⬇️
agent/agent.go 66.90% <76.92%> (-1.60%) ⬇️
coderd/coderd.go 97.52% <100.00%> (ø)
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
coderd/turnconn/turnconn.go 81.91% <0.00%> (-3.20%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947e8f9...9d76d9d. Read the comment docs.

This makes setting up git a bit simpler, and users
can always override these values!

We'll probably add a way to disable our Git integration
anyways, so these could be part of that.
@kylecarbs kylecarbs merged commit 744a00a into main Apr 26, 2022
@kylecarbs kylecarbs deleted the gitinfo branch April 26, 2022 01:03
kylecarbs added a commit that referenced this pull request Jun 10, 2022
This makes setting up git a bit simpler, and users
can always override these values!

We'll probably add a way to disable our Git integration
anyways, so these could be part of that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants