Skip to content

fix: Use proper shutdown signal for systemd #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2022
Merged

fix: Use proper shutdown signal for systemd #1179

merged 1 commit into from
Apr 26, 2022

Conversation

kylecarbs
Copy link
Member

Coder was being killed instantly, which caused builds
to randomly fail!

@kylecarbs
fix: Use proper shutdown signal for systemd
1c5d7d1 
Coder was being killed instantly, which caused builds
to randomly fail!
@kylecarbs kylecarbs requested a review from coadler April 26, 2022 01:25
@kylecarbs kylecarbs self-assigned this Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022 •
edited
Loading

Codecov Report

Merging #1179 (1c5d7d1) into main (744a00a) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
+ Coverage   66.16%   66.24%   +0.07%     
==========================================
  Files         257      263       +6     
  Lines       16394    16615     +221     
  Branches      156      156              
==========================================
+ Hits        10847    11006     +159     
- Misses       4417     4465      +48     
- Partials     1130     1144      +14
Flag Coverage Δ
unittest-go-macos-latest 53.65% <100.00%> (?)
unittest-go-postgres- 65.46% <100.00%> (-0.05%) ⬇️
unittest-go-ubuntu-latest 56.15% <100.00%> (-0.09%) ⬇️
unittest-go-windows-2022 53.21% <100.00%> (?)
unittest-js 67.45% <ø> (ø)
Impacted Files Coverage Δ
agent/agent.go 66.31% <100.00%> (+3.19%) ⬆️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
peerbroker/proxy.go 58.72% <0.00%> (-3.49%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
coderd/workspaceagents.go 56.86% <0.00%> (-1.28%) ⬇️
peer/channel.go 83.23% <0.00%> (-0.58%) ⬇️
provisioner/terraform/provision.go 70.96% <0.00%> (-0.44%) ⬇️
agent/usershell/usershell_darwin.go 100.00% <0.00%> (ø)
cli/ssh_windows.go 0.00% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744a00a...1c5d7d1. Read the comment docs.

@kylecarbs kylecarbs merged commit 8d85d80 into main Apr 26, 2022
@kylecarbs kylecarbs deleted the shutdown branch April 26, 2022 02:09
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Use proper shutdown signal for systemd (#1179)
a60ba37 
Coder was being killed instantly, which caused builds
to randomly fail!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler