feat: Create user page #1197
Merged
feat: Create user page #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug in formErrors story
Doesn't work in test
Codecov Report
@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
+ Coverage 66.00% 66.30% +0.29%
==========================================
Files 265 268 +3
Lines 16751 16817 +66
Branches 157 162 +5
==========================================
+ Hits 11057 11151 +94
+ Misses 4533 4508 -25
+ Partials 1161 1158 -3
Continue to review full report at Codecov.
|
This reverts commit cf8442f.
presleyp
commented
Apr 28, 2022
|
|
||
| export const CreateUserPage: React.FC = () => { | ||
| const xServices = useContext(XServiceContext) | ||
| const myOrgId = useSelector(xServices.authXService, selectOrgId) |
There was a problem hiding this comment.
Doing this instead of getting authState using useActor means that this component will only re-render in response to changes in the org id, not all authXService changes. I haven't bothered with this approach in other places yet because so far it's been components that have a lot to do with the XService they're accessing and there probably won't be many irrelevant updates, but we should do this for cases where we only care about a little piece of some global state.
presleyp
commented
Apr 28, 2022
| email: "", | ||
| password: "", | ||
| username: "", | ||
| organization_id: myOrgId, |
There was a problem hiding this comment.
I just hard-coded the org id in here; in EE we'll need a drop-down field for it.
presleyp
commented
Apr 28, 2022
| target: "idle", | ||
| actions: ["assignCreateUserError"], | ||
| }, | ||
| ], |
There was a problem hiding this comment.
This works like a switch statement - if the cond is true on the first case, do that, otherwise try the next case.
greyscaled
approved these changes
Apr 28, 2022
Comment on lines
+76
to
+86
| onError: [ | ||
| { | ||
| target: "idle", | ||
| cond: "isFormError", | ||
| actions: ["assignCreateUserFormErrors"], | ||
| }, | ||
| { | ||
| target: "idle", | ||
| actions: ["assignCreateUserError"], | ||
| }, | ||
| ], |
Co-authored-by: G r e y <grey@coder.com>
presleyp
commented
Apr 28, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Add button and route * Hook up api * Lint * Add basic form * Get users on page mount * Make cancel work * Creating -> idle bc users page refetches * Import as TypesGen * Handle api errors * Lint * Add handler * Add FormFooter * Add FullPageForm * Lint * Better form, error, stories bug in formErrors story * Make detail optional * Use Language * Remove detail prop * Add back autoFocus * Remove displayError, use displaySuccess * Lint, export Language * Tests - wip * Fix cancel tests * Switch back to mock * Add navigate to xservice Doesn't work in test * Move error type predicate to xservice * Lint * Switch to using creation mode in XState still problems in tests * Lint * Lint * Lint * Revert "Switch to using creation mode in XState" This reverts commit cf8442f. * Give XService a navigate action * Add missing validation messages * Fix XState warning * Fix tests IRL is broken bc I need to send org id * Pretend user has org id and make it work * Format * Lint * Switch to org ids array * Skip lines between tests Co-authored-by: G r e y <grey@coder.com> * Punctuate notification messages Co-authored-by: G r e y <grey@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #1184Fixes #734
I'm pretending users come with org ids in preparation for Bruno's PRselectorto get the org id out of theauthXServicewithout making theCreateUserPagere-render for every change toauthXServiceCreateUserFormstories have a flash of a validation error message. That appears to be a Storybook problem where it thinks the field istouchedmomentarily, maybe a lag from looking at a related story.navigatein an action like @BrunoQuaresma suggested. I prefer this over embedding it incontextbecause in the latter solution, the XService has to know our routes.