feat: add filter by status on GET /users #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@presleyp this is a bit different from what we discussed in the epic but I think it is better since allows us to easily filter users using other statuses. What do you think? |
Codecov Report
@@ Coverage Diff @@
## main #1206 +/- ##
==========================================
+ Coverage 65.48% 65.69% +0.21%
==========================================
Files 265 268 +3
Lines 16950 17020 +70
Branches 157 162 +5
==========================================
+ Hits 11099 11182 +83
+ Misses 4692 4678 -14
- Partials 1159 1160 +1
Continue to review full report at Codecov.
|
Emyrk
requested changes
Apr 28, 2022
presleyp
approved these changes
Apr 28, 2022
Emyrk
reviewed
Apr 28, 2022
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
Emyrk
approved these changes
Apr 29, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #662 (comment)
Reason: The FE needs to get only the active users for now, so I think the best way for doing that is to add a filter on the GET /users endpoint so the FE can do /users?status=active.