Skip to content

fix: Update buildinfo package location in ldflags #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix: Update buildinfo package location in ldflags #1208

merged 1 commit into from
Apr 28, 2022

Conversation

kylecarbs
Copy link
Member

This was causing the version to not be injected!

@kylecarbs
fix: Update buildinfo package location in ldflags
5b6942c 
This was causing the version to not be injected!
@kylecarbs kylecarbs requested a review from code-asher April 28, 2022 14:36
@kylecarbs kylecarbs self-assigned this Apr 28, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) April 28, 2022 14:36
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #1208 (5b6942c) into main (816441e) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
+ Coverage   66.00%   66.12%   +0.11%     
==========================================
  Files         265      265              
  Lines       16751    16751              
  Branches      157      157              
==========================================
+ Hits        11057    11076      +19     
+ Misses       4533     4521      -12     
+ Partials     1161     1154       -7
Flag Coverage Δ
unittest-go-macos-latest 53.59% <ø> (+0.13%) ⬆️
unittest-go-postgres- 65.30% <ø> (+0.05%) ⬆️
unittest-go-ubuntu-latest 56.03% <ø> (+0.01%) ⬆️
unittest-go-windows-2022 53.07% <ø> (+0.01%) ⬆️
unittest-js 66.50% <ø> (ø)
Impacted Files Coverage Δ
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
coderd/provisionerdaemons.go 62.28% <0.00%> (-0.51%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (ø)
peer/conn.go 81.72% <0.00%> (+0.25%) ⬆️
coderd/workspaceagents.go 55.59% <0.00%> (+0.95%) ⬆️
provisionerd/provisionerd.go 77.91% <0.00%> (+1.74%) ⬆️
coderd/httpapi/httpapi.go 72.50% <0.00%> (+6.25%) ⬆️
provisionersdk/serve.go 43.24% <0.00%> (+8.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816441e...5b6942c. Read the comment docs.

code-asher
code-asher approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops my bad! Nice find!

@kylecarbs kylecarbs merged commit eea9729 into main Apr 28, 2022
@kylecarbs kylecarbs deleted the buildtag branch April 28, 2022 15:46
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Update buildinfo package location in ldflags (#1208)
b97f37b 
This was causing the version to not be injected!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @code-asher