Skip to content

fix: ensure rtc state changes can't log after close #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix: ensure rtc state changes can't log after close #1213

merged 1 commit into from
Apr 28, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 28, 2022

No description provided.

@coadler coadler self-assigned this Apr 28, 2022
@coadler coadler requested a review from kylecarbs April 28, 2022 18:14
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #1213 (3140a58) into main (e330dc1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
- Coverage   65.43%   65.41%   -0.02%     
==========================================
  Files         265      265              
  Lines       16937    16946       +9     
  Branches      157      157              
==========================================
+ Hits        11083    11086       +3     
- Misses       4694     4700       +6     
  Partials     1160     1160
Flag Coverage Δ
unittest-go-macos-latest 52.98% <0.00%> (+0.08%) ⬆️
unittest-go-postgres- 64.53% <0.00%> (-0.14%) ⬇️
unittest-go-ubuntu-latest 55.31% <0.00%> (-0.10%) ⬇️
unittest-go-windows-2022 52.46% <0.00%> (-0.04%) ⬇️
unittest-js 66.50% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 78.41% <0.00%> (-3.32%) ⬇️
peerbroker/listen.go 82.35% <0.00%> (-5.05%) ⬇️
agent/agent.go 66.31% <0.00%> (-0.71%) ⬇️
coderd/provisionerdaemons.go 62.79% <0.00%> (-0.51%) ⬇️
provisionerd/provisionerd.go 76.30% <0.00%> (-0.41%) ⬇️
provisioner/terraform/provision.go 71.39% <0.00%> (+0.43%) ⬆️
coderd/workspaceagents.go 58.14% <0.00%> (+1.27%) ⬆️
peer/channel.go 84.97% <0.00%> (+1.73%) ⬆️
provisioner/echo/serve.go 59.20% <0.00%> (+4.80%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e330dc1...3140a58. Read the comment docs.

@kylecarbs kylecarbs mentioned this pull request Apr 28, 2022
Closed
@coadler coadler merged commit 82364d1 into main Apr 28, 2022
@coadler coadler deleted the colin/fix-conn-log-close branch April 28, 2022 21:39
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@coadler @kylecarbs
fix: ensure rtc state changes can't log after close (#1213)
d8d8664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @kylecarbs @misskniss