Skip to content

fix: improve clipboard support on HTTP connections and older browsers #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2024
Merged

fix: improve clipboard support on HTTP connections and older browsers #12178

merged 2 commits into from
Feb 15, 2024

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Feb 15, 2024 •
edited
Loading

Closes #12171

Changes made

  • Makes sure that on older browsers and HTTP-only deployments, trying to copy to a clipboard succeeds

Other notes

  • Will be making some new tests around all our clipboard functionality shortly. Just wanted to get this out as a hotfix
  • The method that makes this workaround possible relies is officially deprecated. As mentioned here, there is a real possibility down the line that we will not be able to support HTTP-only users going forward without even more workarounds that go beyond polyfilling clipboard logic

@Parkreiner Parkreiner self-assigned this Feb 15, 2024
cdr-bot[bot]
cdr-bot bot approved these changes Feb 15, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner changed the title fix: add future-proofing for clipboard copies on http connections fix: let users copy clipboard values on HTTP connections and older browsers Feb 15, 2024
@Parkreiner Parkreiner changed the title fix: let users copy clipboard values on HTTP connections and older browsers fix: resolve edge case for copying to clipboard when using HTTP connections and older browsers Feb 15, 2024
@Parkreiner Parkreiner changed the title fix: resolve edge case for copying to clipboard when using HTTP connections and older browsers fix: improve clipboard support on HTTP connections and older browsers Feb 15, 2024
@Parkreiner Parkreiner merged commit fbd436c into main Feb 15, 2024
@Parkreiner Parkreiner deleted the mes/clipboard-http-fix branch February 15, 2024 21:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to copy session token from the cli-auth page
1 participant
@Parkreiner