Skip to content

refactor: move auto fill feature into an experiment #12230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2024
Merged

refactor: move auto fill feature into an experiment #12230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f06c492
refactor: move auto fill feature into an experiment
BrunoQuaresma Feb 20, 2024
9f4a949
Update deployment.go
BrunoQuaresma Feb 21, 2024
c14a6ac
Merge branch 'main' of https://github.com/coder/coder into bq/move-au…
BrunoQuaresma Feb 21, 2024
505e424
Merge branch 'bq/move-autofill-to-experimental' of https://github.com…
BrunoQuaresma Feb 21, 2024
2b19023
Merge branch 'main' of https://github.com/coder/coder into bq/move-au…
BrunoQuaresma Feb 21, 2024
438439b
Fix gen
BrunoQuaresma Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions coderd/apidoc/docs.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions coderd/apidoc/swagger.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions codersdk/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2117,8 +2117,9 @@ type Experiment string

const (
// Add new experiments here!
ExperimentExample Experiment = "example" // This isn't used for anything.
ExperimentSharedPorts Experiment = "shared-ports"
ExperimentExample Experiment = "example" // This isn't used for anything.
ExperimentSharedPorts Experiment = "shared-ports"
ExperimentAutoFillParameters Experiment = "auto-fill-parameters" // This should not be taken out of experiments until we have redesigned the feature.
)

// ExperimentsAll should include all experiments that are safe for
Expand Down
9 changes: 5 additions & 4 deletions docs/api/schemas.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions site/src/api/typesGenerated.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 9 additions & 6 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { paramsUsedToCreateWorkspace } from "utils/workspace";
import { CreateWorkspacePageView } from "./CreateWorkspacePageView";
import { CreateWSPermissions, createWorkspaceChecks } from "./permissions";
import { generateWorkspaceName } from "modules/workspaces/generateWorkspaceName";
import { useDashboard } from "modules/dashboard/useDashboard";

export const createWorkspaceModes = ["form", "auto", "duplicate"] as const;
export type CreateWorkspaceMode = (typeof createWorkspaceModes)[number];
Expand All @@ -40,6 +41,7 @@ const CreateWorkspacePage: FC = () => {
const [searchParams, setSearchParams] = useSearchParams();
const mode = getWorkspaceMode(searchParams);
const customVersionId = searchParams.get("version") ?? undefined;
const { experiments } = useDashboard();

const defaultName = searchParams.get("name");

Expand All @@ -51,12 +53,6 @@ const CreateWorkspacePage: FC = () => {

const templateQuery = useQuery(templateByName(organizationId, templateName));

const userParametersQuery = useQuery({
queryKey: ["userParameters"],
queryFn: () => getUserParameters(templateQuery.data!.id),
enabled: templateQuery.isSuccess,
});

const permissionsQuery = useQuery(
checkAuthorization({
checks: createWorkspaceChecks(organizationId),
Expand Down Expand Up @@ -97,6 +93,13 @@ const CreateWorkspacePage: FC = () => {
[navigate],
);

// Auto fill parameters
const userParametersQuery = useQuery({
queryKey: ["userParameters"],
queryFn: () => getUserParameters(templateQuery.data!.id),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will templateQuery.data ever be null or undefined?

enabled:
experiments.includes("auto-fill-parameters") && templateQuery.isSuccess,
});
const autofillParameters = getAutofillParameters(
searchParams,
userParametersQuery.data ? userParametersQuery.data : [],
Expand Down