Skip to content

test: Regenerate GitSSHKey flake when comparing times #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2022
Merged

Conversation

kylecarbs
Copy link
Member

This is a crazy one! The in-memory DB is fast, which allows the same
exact timestamp to occur for regenerating the key!

See: https://github.com/coder/coder/runs/6234173911?check_suite_focus=true#step:9:82

This is a crazy one! The in-memory DB is fast, which allows the same
exact timestamp to occur for regenerating the key!

See: https://github.com/coder/coder/runs/6234173911?check_suite_focus=true#step:9:82
@kylecarbs kylecarbs requested a review from f0ssel April 29, 2022 22:57
@kylecarbs kylecarbs self-assigned this Apr 29, 2022
@kylecarbs
Copy link
Member Author

Happened in #1231

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1235 (7f62505) into main (81577f1) will increase coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
+ Coverage   65.33%   65.76%   +0.43%     
==========================================
  Files         266      272       +6     
  Lines       17651    17872     +221     
  Branches      192      192              
==========================================
+ Hits        11532    11754     +222     
- Misses       4880     4886       +6     
+ Partials     1239     1232       -7     
Flag Coverage Δ
unittest-go-macos-latest 53.19% <ø> (?)
unittest-go-postgres- 64.83% <ø> (-0.02%) ⬇️
unittest-go-ubuntu-latest 55.54% <ø> (?)
unittest-go-windows-2022 52.76% <ø> (?)
unittest-js 69.96% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
coderd/workspaceagents.go 56.77% <0.00%> (-0.94%) ⬇️
provisionerd/provisionerd.go 75.76% <0.00%> (-0.54%) ⬇️
coderd/provisionerdaemons.go 62.79% <0.00%> (ø)
pty/pty_windows.go 74.62% <0.00%> (ø)
cli/ssh_windows.go 0.00% <0.00%> (ø)
agent/usershell/usershell_windows.go 83.33% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
pty/start_windows.go 66.95% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81577f1...7f62505. Read the comment docs.

@kylecarbs kylecarbs merged commit e15566c into main Apr 30, 2022
@kylecarbs kylecarbs deleted the gitkeyflake branch April 30, 2022 01:19
kylecarbs added a commit that referenced this pull request Jun 10, 2022
This is a crazy one! The in-memory DB is fast, which allows the same
exact timestamp to occur for regenerating the key!

See: https://github.com/coder/coder/runs/6234173911?check_suite_focus=true#step:9:82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants