Skip to content

fix: Add "GIT_COMMITTER_*" to remove Git prompt #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2022
Merged

fix: Add "GIT_COMMITTER_*" to remove Git prompt #1236

merged 1 commit into from
Apr 30, 2022

Conversation

kylecarbs
Copy link
Member

A prompt would appear to globally configure the email or name
before. We already have this information, so we can set the
environment variables!

A prompt would appear to globally configure the email or name
before. We already have this information, so we can set the
environment variables!
@kylecarbs kylecarbs requested review from Emyrk and coadler April 29, 2022 23:11
@kylecarbs kylecarbs self-assigned this Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1236 (902aaca) into main (81577f1) will increase coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
+ Coverage   65.33%   65.83%   +0.50%     
==========================================
  Files         266      272       +6     
  Lines       17651    17875     +224     
  Branches      192      192              
==========================================
+ Hits        11532    11768     +236     
+ Misses       4880     4879       -1     
+ Partials     1239     1228      -11     
Flag Coverage Δ
unittest-go-macos-latest 53.23% <100.00%> (?)
unittest-go-postgres- 64.84% <100.00%> (-0.02%) ⬇️
unittest-go-ubuntu-latest 55.58% <100.00%> (?)
unittest-go-windows-2022 52.77% <100.00%> (?)
unittest-js 69.96% <ø> (ø)
Impacted Files Coverage Δ
agent/agent.go 67.08% <100.00%> (+2.12%) ⬆️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
peerbroker/listen.go 82.35% <0.00%> (-3.37%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
pty/start_windows.go 66.95% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
agent/usershell/usershell_darwin.go 100.00% <0.00%> (ø)
agent/usershell/usershell_windows.go 83.33% <0.00%> (ø)
pty/pty_windows.go 74.62% <0.00%> (ø)
cli/ssh_windows.go 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81577f1...902aaca. Read the comment docs.

@coadler coadler enabled auto-merge (squash) April 29, 2022 23:59
@coadler coadler merged commit 2acdd3b into main Apr 30, 2022
@coadler coadler deleted the gitflags branch April 30, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants