fix: ensure auto-workspace creation waits until all parameters are ready #12419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
commented
Mar 4, 2024
Comment on lines
+131
to
+132
| const autoStartReady = | ||
| mode === "auto" && (!autofillEnabled || userParametersQuery.isSuccess); |
There was a problem hiding this comment.
Defining this outside seemed like the more manageable thing to do, since this needs to evaluate twelve combinations:
- The value of mode (form, auto, duplicate)
- The value of autofillEnabled (true or false)
- The value of userParametersQuery.isSuccess (true or false)
Combining them into a single boolean makes sure the effect only has to worry about three situations:
- Mounting render
- Value flips from false to true
- Value flips from true to false
BrunoQuaresma
approved these changes
Mar 5, 2024
|
@BrunoQuaresma Yeah, that's perfectly reasonable. I was off today, so I'm going to reclassify this change as a hotfix to make it more clear that it's a small-scale change for now, and get it in faster. And then I'll make a separate PR with the new test assertions (realistically it'll be Sunday before I start working on that) |
![cdr-bot[bot]](https://avatars.githubusercontent.com/in/338482?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue to link – realized we had a bug when I was looking at some of the Slack messages today
Changes made
userParametersQuerysucceeds with fetching its data before it's allowed to start making a new workspaceuseEffectdependency array