Skip to content

chore: add workspace id filter on api #12483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 8, 2024

In another branch I am working on, I require this. It's a good feature though regardless, so I extended it to the search.

Example search query:

owner:me id:a6855077-9a36-4254-87b5-d3251ceeb8e3,aa483f4b-3dea-4d64-8f08-3f28d00e8152

@Emyrk Emyrk requested a review from johnstcn March 11, 2024 14:57
@@ -1356,6 +1356,33 @@ func TestWorkspaceFilterManual(t *testing.T) {
require.NoError(t, err)
require.Len(t, res.Workspaces, 0)
})
t.Run("IDs", func(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: test with multiple IDs

@Emyrk Emyrk merged commit e3051df into main Mar 11, 2024
@Emyrk Emyrk deleted the stevenmasley/by_workspace_ids branch March 11, 2024 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants