Skip to content

fix(install.sh): install from github when using --stable on macOS #13216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented May 9, 2024

Similar to the existing behavior for the --version flag. Our Homebrew tap only tracks mainline, so using it when --stable is passed in will always result in an incorrect version being installed.

@aslilac aslilac requested a review from stirby May 9, 2024 18:24
Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the super quick turnaround!

@aslilac aslilac merged commit e14f8fb into main May 9, 2024
@aslilac aslilac deleted the install-stable-standalone-on-macos branch May 9, 2024 19:14
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants