Skip to content

chore: add cleanup callbacks to some useEffect calls #13444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jun 3, 2024

Closes #13422

Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Had some comments about possibly making the code more clear, but that doesn't have anything to do with what you wrote. Everything right now is 100% an improvement

@aslilac aslilac merged commit 0ea89a3 into main Jun 4, 2024
28 checks passed
@aslilac aslilac deleted the effect-cleanup branch June 4, 2024 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Clean up buggy useEffect calls
2 participants