Skip to content

chore(coderd): add update user profile test for members #13463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jun 4, 2024

Relates to #13454

Previously we had only been testing that the first user was able to update user profiles.
This change adds a separate test that a member user is able to update their own user profile.

@johnstcn johnstcn self-assigned this Jun 4, 2024
@johnstcn johnstcn changed the title chore: test update user profile as member chore(coderd): add update user profile test for members Jun 4, 2024
@johnstcn johnstcn requested a review from mtojek June 4, 2024 13:00
t.Parallel()
auditor := audit.NewMock()
client := coderdtest.New(t, &coderdtest.Options{Auditor: auditor})
numLogs := len(auditor.AuditLogs())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to assert that the change gets audit-logged.

@johnstcn johnstcn merged commit 168d2d6 into main Jun 4, 2024
34 checks passed
@johnstcn johnstcn deleted the cj/test-update-user-profile-as-member branch June 4, 2024 13:17
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants