Skip to content

fix: Group subcommands for cognitive ease #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2022
Merged

fix: Group subcommands for cognitive ease #1351

merged 1 commit into from
May 9, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented May 9, 2022

Fixes #1324.

I removed the ASCII logo too. It was cool, but not worth the prime real estate.

image

@kylecarbs kylecarbs requested a review from coadler May 9, 2022 20:43
@kylecarbs kylecarbs self-assigned this May 9, 2022
@kylecarbs kylecarbs requested a review from ammario May 9, 2022 20:57
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1351 (8ea93b2) into main (f5693df) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1351      +/-   ##
==========================================
+ Coverage   66.58%   66.90%   +0.32%     
==========================================
  Files         284      280       -4     
  Lines       18593    18466     -127     
  Branches      235      235              
==========================================
- Hits        12380    12355      -25     
+ Misses       4950     4845     -105     
- Partials     1263     1266       +3     
Flag Coverage Δ
unittest-go-macos-latest 54.06% <100.00%> (+0.33%) ⬆️
unittest-go-postgres- 65.64% <100.00%> (+0.49%) ⬆️
unittest-go-ubuntu-latest 56.48% <100.00%> (+0.21%) ⬆️
unittest-go-windows-2022 52.42% <100.00%> (+0.35%) ⬆️
unittest-js 73.67% <ø> (ø)
Impacted Files Coverage Δ
cli/autostart.go 75.29% <100.00%> (+0.29%) ⬆️
cli/configssh.go 69.06% <100.00%> (+0.45%) ⬆️
cli/create.go 56.95% <100.00%> (+0.28%) ⬆️
cli/delete.go 25.00% <100.00%> (+5.76%) ⬆️
cli/list.go 9.52% <100.00%> (+2.96%) ⬆️
cli/login.go 55.85% <100.00%> (+0.23%) ⬆️
cli/publickey.go 76.92% <100.00%> (+0.92%) ⬆️
cli/root.go 79.43% <100.00%> (+0.29%) ⬆️
cli/server.go 57.58% <100.00%> (+0.07%) ⬆️
cli/show.go 23.07% <100.00%> (+6.41%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5693df...8ea93b2. Read the comment docs.

cli/autostart.go Outdated
Comment on lines 21 to 23
Annotations: map[string]string{
"workspace": "",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Annotations: map[string]string{
"workspace": "",
},
Annotations: workspaceCommand,

@kylecarbs kylecarbs enabled auto-merge (squash) May 9, 2022 21:41
@kylecarbs kylecarbs disabled auto-merge May 9, 2022 21:46
@kylecarbs kylecarbs merged commit ddb9631 into main May 9, 2022
@kylecarbs kylecarbs deleted the separatecmd branch May 9, 2022 22:42
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group subcommands better for cognitive ease
3 participants