Skip to content

docs: fix docs on deploying workspaces in additional namespaces #13724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

ericpaulsen
Copy link
Member

our docs incorrectly point users to creating a new ServiceAccount and token for deploying workspaces in additional namespaces.

the coder Service Account is already created as a part of the Helm install, so only a Role and RoleBinding are needed to properly give permissions.

let me know if i'm missing something here.

@ericpaulsen ericpaulsen added the docs Area: coder.com/docs label Jun 28, 2024
@ericpaulsen ericpaulsen self-assigned this Jun 28, 2024
@ericpaulsen ericpaulsen changed the title fix-sa-docs docs: fix additional clusters documentation Jun 28, 2024
@matifali
Copy link
Member

matifali commented Jul 1, 2024

Haven't personally verified the updated instructions but changes make sense. LGTM.

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bring the changes into our restructure branch.

Thanks Eric.

@ericpaulsen ericpaulsen enabled auto-merge (squash) July 2, 2024 01:10
@matifali matifali disabled auto-merge July 3, 2024 19:23
@matifali matifali changed the title docs: fix additional clusters documentation fix-sa-docs Jul 3, 2024
@matifali matifali enabled auto-merge (squash) July 3, 2024 19:23
@matifali matifali changed the title fix-sa-docs docs: fix docs on deploying workspaces in additional namespaces Jul 3, 2024
@ericpaulsen
Copy link
Member Author

@matifali do you know why CI is still pending?

@matifali matifali merged commit 90a6025 into main Jul 10, 2024
26 checks passed
@matifali matifali deleted the fix-sa-docs branch July 10, 2024 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants