docs: fix docs on deploying workspaces in additional namespaces #13724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
approved these changes
Jul 1, 2024
|
Haven't personally verified the updated instructions but changes make sense. LGTM. |
stirby
approved these changes
Jul 1, 2024
matifali
changed the title
|
@matifali do you know why CI is still pending? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our docs incorrectly point users to creating a new ServiceAccount and token for deploying workspaces in additional namespaces.
the
coderService Account is already created as a part of the Helm install, so only a Role and RoleBinding are needed to properly give permissions.let me know if i'm missing something here.