chore: fix up migration number fixer #14266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
usesgit mv
which is more idiomatic for renamesThis script still relies on folks needing a version of Bash not shipped with MacOS by default.
I'm using this version, so it works, but it doesn't work natively for folks running the default.
$ which bash /opt/homebrew/bin/bash $ bash --version GNU bash, version 5.2.26(1)-release (aarch64-apple-darwin23.2.0) # Default version $ /bin/bash --version GNU bash, version 3.2.57(1)-release (arm64-apple-darwin23)
I created a Go equivalent in https://github.com/coder/coder/compare/dk/fix-migs which we could consider moving to.
It's a bit simpler (doesn't pull the given branch - trying to be more UNIXy), and requires a regex to match a file needing a rename, so it's more dumb but more explicit.