feat: add provisioners view to organization settings #14501
Conversation
aslilac
changed the title
|
Both organization provisioners and groups are enterprise features, however groups displays the enterprise banner but for provisioners an error message is displayed. It would make sense for both of these cases to have the same behavior and show the 
|
|
Asking this mainly because I want to update the docs and want to fully understand the terminology. How did you decide that Provisioner.tsx and ProvisionerTag.tsx are modules and something like OrganizationAutocomplete or Paywall is a component? Should OrganizationAutocomplete or Paywall actually have been modules? |
|
I think |
|
Nice, I like the distinction that Components could be technically be used in any project and still make sense. |
| > | ||
| <PageHeaderTitle>Provisioners</PageHeaderTitle> | ||
| </PageHeader> | ||
| <Stack spacing={4.5}> |
There was a problem hiding this comment.
I feel the way this is defined gap: spacing * 8, sort of constrains the UI to consistent spacing in multiples of 8 if we only use whole numbers for spacing. I would argue that for consistency we should keep whole numbers or rethink the spacing * 8 definition.
There was a problem hiding this comment.
I think we should rethink the * 8 definition. If you do a search for spacing={ you'll see that the codebase is already covered in .5 spacings. 😅 This is just the spacing that the health page already uses, and I think it looks right.
site/src/pages/ManagementSettingsPage/OrganizationProvisionersPageView.tsx
Outdated
Show resolved
Hide resolved
…PageView.tsx Co-authored-by: Jaayden Halko <jaayden.halko@gmail.com>
Closes #14436
Warnings aren't implemented yet on the backend, but the rest of this should be ready to go! I can handle those as part of another PR to avoid blocking this work if they're not done soon.