Skip to content

feat: add provisioners view to organization settings #14501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 4, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 30, 2024

Closes #14436

  • View details about each provisioner such as scope and version (PSK tags and other details will be handled in a separate ticket)
  • View details about each provisioner such as name, tags, created at, last used
  • View provisioner warnings
  • CTA to create a new provisioner (links to docs)
  • Add storybooks

Warnings aren't implemented yet on the backend, but the rest of this should be ready to go! I can handle those as part of another PR to avoid blocking this work if they're not done soon.

@aslilac aslilac changed the title feat: view provisioners from organization settings feat: add provisioners view to organization settings Sep 3, 2024
@aslilac aslilac marked this pull request as ready for review September 3, 2024 22:09
@jaaydenh
Copy link
Contributor

jaaydenh commented Sep 4, 2024

Both organization provisioners and groups are enterprise features, however groups displays the enterprise banner but for provisioners an error message is displayed. It would make sense for both of these cases to have the same behavior and show the Paywall component.

Screenshot 2024-09-04 at 2 42 02 PM

@jaaydenh
Copy link
Contributor

jaaydenh commented Sep 4, 2024

Asking this mainly because I want to update the docs and want to fully understand the terminology. How did you decide that Provisioner.tsx and ProvisionerTag.tsx are modules and something like OrganizationAutocomplete or Paywall is a component? Should OrganizationAutocomplete or Paywall actually have been modules?

@aslilac
Copy link
Member Author

aslilac commented Sep 4, 2024

I think OrganizationAutocomplete and Paywall should actually both be in modules/ as well. I think "components" are atomic, simple, and not tied to our specific product; they should be useful in other settings as well.

@jaaydenh
Copy link
Contributor

jaaydenh commented Sep 4, 2024

Nice, I like the distinction that Components could be technically be used in any project and still make sense.

>
<PageHeaderTitle>Provisioners</PageHeaderTitle>
</PageHeader>
<Stack spacing={4.5}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the way this is defined gap: spacing * 8, sort of constrains the UI to consistent spacing in multiples of 8 if we only use whole numbers for spacing. I would argue that for consistency we should keep whole numbers or rethink the spacing * 8 definition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rethink the * 8 definition. If you do a search for spacing={ you'll see that the codebase is already covered in .5 spacings. 😅 This is just the spacing that the health page already uses, and I think it looks right.

…PageView.tsx

Co-authored-by: Jaayden Halko <jaayden.halko@gmail.com>
@jaaydenh jaaydenh self-requested a review September 4, 2024 20:10
Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aslilac aslilac merged commit 84922e2 into main Sep 4, 2024
27 checks passed
@aslilac aslilac deleted the org-provisioners-page branch September 4, 2024 22:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Organization Provisioners Page
2 participants