Skip to content

chore(docs): correct inaccuracies in the "Docker in Workspaces" page #14546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

phorcys420
Copy link
Member

The Sysbox part does not mention that it also works with regular Docker, this has caused confusion for one of our users in the Discord.
The wording I've used for the Sysbox part might not be the best, feel free to adjust the wording :-)

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Phorcys! Would you mind adding these to the restructure-new branch too?

@phorcys420 phorcys420 changed the base branch from main to restructure-new September 3, 2024 18:34
@phorcys420
Copy link
Member Author

sure @stirby, changed the base branch!

@phorcys420
Copy link
Member Author

ugh, this did introduce some other changes, let me fix this

@phorcys420 phorcys420 changed the base branch from restructure-new to main September 3, 2024 18:43
@phorcys420
Copy link
Member Author

@stirby let's merge this into main and i'll merge restructure-new with main right after

@phorcys420 phorcys420 merged commit 4421063 into main Sep 3, 2024
30 of 31 checks passed
@phorcys420 phorcys420 deleted the fix-sysbox-inaccuracy-in-docs branch September 3, 2024 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants