• fix: make cli respect deployment --docs-url #14568 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite

(No changes in previous push, just rebase)

If we're going to fetch the deployment config on startup, I think making it optional middlware, instead of making it part of say, initClient is better - no CLI command has needed anything from the deployment config up until now.

I only just noticed these tests failed, because viewing deployment config is restricted - I still think just having a docsURL function that fetches and otherwise defaults to the main docs is the best way to do this.

Nah, I had to rethink it all - most admins are probably not giving regular users permissions to view the deployment config, so it needs to be included on /appearance, enterprise only, but presumably they're the only ones using offline docs. Basically a new PR altogether, so ignore the force push diff :D

I think I've missed a few doc links, so I'll get to those next

This approach is definitely better, but since opening this PR we've added a docs link to a help command. We can't plumb the fetched appearance config there (nor would we want to do a fetch before a help command), so I'm not totally sure what to do about that. It would be nice if we could just an additional field to a local config, but the cli stores session and url as whole files, and it feels a bit ridiculous to add a new file just for the docs url.