test(site): move users page test to storybook #14579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
requested review from
code-asher
and removed request for
a team
code-asher
approved these changes
Sep 5, 2024
| @@ -0,0 +1,577 @@ | |||
| import type { LoginType, User, UserStatus } from "api/typesGenerated"; | |||
There was a problem hiding this comment.
Should we replace all the emails with fake ones? Some of these are probably real (the Coder ones at least, maybe the ones from ChatGPT too).
There was a problem hiding this comment.
Ah, sorry, I thought I had removed all of them. 🤦
| // These values were retrieved from the Coder API. Sensitive information such as | ||
| // usernames, names, and emails has been replaced with fake user data to protect | ||
| // privacy. This user data comes from the MockUsers to keep consistency. | ||
| export const MockGroups: Group[] = [ |
There was a problem hiding this comment.
Should we replace/remove the ones with external avatar URLs? Could be weird if our tests are making requests for these external jpgs and such
| await user.click( | ||
| within(userRow).getByLabelText("Auditor", { exact: false }), | ||
| ); | ||
| await within(document.body).findByText("Error updating the user roles."); |
There was a problem hiding this comment.
Looks like the error text is Error on updating the user roles.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using Storybook interaction tests, we improve the developer experience, as we can see what is happening in the browser, use browser tools to debug, and snapshot the component after interactions, making our tests more reliable and easier to maintain.
Fixes #14535