chore: align active version terminology and link to docs #14639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
johnstcn
reviewed
Sep 11, 2024
site/src/pages/TemplateVersionEditorPage/PublishTemplateVersionDialog.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
mafredri
approved these changes
Sep 11, 2024
site/src/pages/TemplateVersionEditorPage/PublishTemplateVersionDialog.tsx
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this quite confusing when I came across this feature.
What is the "default version"? I've changed this to "active version" which I believe is the intent here, and added a link to the documentation.
I also linked the docs in the CLI
--require-active-versionflags' help text.