chore: remove tailnet v1 API support #14641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
spikecurtis
force-pushed
the
spike/legacy-agent-ip
branch
from
dc5927c to
e95c7bd
Compare
spikecurtis
force-pushed
the
spike/remove-v1-tailnet
branch
from
d9c89d3 to
2f00bd9
Compare
spikecurtis
force-pushed
the
spike/legacy-agent-ip
branch
from
e95c7bd to
4f41732
Compare
spikecurtis
force-pushed
the
spike/remove-v1-tailnet
branch
from
44596a9 to
2d609da
Compare
spikecurtis
force-pushed
the
spike/legacy-agent-ip
branch
from
4f41732 to
bc16937
Compare
spikecurtis
force-pushed
the
spike/remove-v1-tailnet
branch
from
2d609da to
64abeb7
Compare
spikecurtis
commented
Sep 11, 2024
| @@ -683,7 +592,13 @@ func TestPGCoordinator_Unhealthy(t *testing.T) { | |||
| logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug) | |||
|
|
|||
| calls := make(chan struct{}) | |||
| // first call succeeds, so that our Agent will successfully connect. | |||
There was a problem hiding this comment.
previously, we started a pipe connection and used the v1 API over it. This eventually calls Coordinate(), but starting the pipe didn't block on Coordinate() returning.
With the v2 API, we synchronously call Coordinate() from the main test goroutine, so we need to get an initially successful heartbeat to unblock the Coordinate() call or this test would deadlock.
spikecurtis
force-pushed
the
spike/remove-v1-tailnet
branch
from
64abeb7 to
a5b7eac
Compare
spikecurtis
force-pushed
the
spike/legacy-agent-ip
branch
from
bc16937 to
46730d8
Compare
spikecurtis
force-pushed
the
spike/remove-v1-tailnet
branch
from
a5b7eac to
f785a08
Compare
deansheather
approved these changes
Sep 11, 2024
Merge activity
|
spikecurtis
changed the base branch from
spike/legacy-agent-ip
to
graphite-base/14641
spikecurtis
force-pushed
the
spike/remove-v1-tailnet
branch
from
f785a08 to
5560316
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for v1 of the tailnet API, which was the original coordination protocol where we only sent node updates, never marked them lost or disconnected.
v2 of the tailnet API went GA for CLI clients in Coder 2.8.0, so clients older than that would stop working.