Skip to content

chore: remove tailnet v1 API support #14641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Sep 11, 2024

Drops support for v1 of the tailnet API, which was the original coordination protocol where we only sent node updates, never marked them lost or disconnected.

v2 of the tailnet API went GA for CLI clients in Coder 2.8.0, so clients older than that would stop working.

Copy link
Contributor Author

spikecurtis commented Sep 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis marked this pull request as ready for review September 11, 2024 09:59
@spikecurtis spikecurtis force-pushed the spike/remove-v1-tailnet branch from d9c89d3 to 2f00bd9 Compare September 11, 2024 10:08
@spikecurtis spikecurtis force-pushed the spike/remove-v1-tailnet branch from 44596a9 to 2d609da Compare September 11, 2024 10:28
@spikecurtis spikecurtis force-pushed the spike/remove-v1-tailnet branch from 2d609da to 64abeb7 Compare September 11, 2024 12:00
@@ -683,7 +592,13 @@ func TestPGCoordinator_Unhealthy(t *testing.T) {
logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug)

calls := make(chan struct{})
// first call succeeds, so that our Agent will successfully connect.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, we started a pipe connection and used the v1 API over it. This eventually calls Coordinate(), but starting the pipe didn't block on Coordinate() returning.

With the v2 API, we synchronously call Coordinate() from the main test goroutine, so we need to get an initially successful heartbeat to unblock the Coordinate() call or this test would deadlock.

@spikecurtis spikecurtis force-pushed the spike/remove-v1-tailnet branch from 64abeb7 to a5b7eac Compare September 11, 2024 12:57
@spikecurtis spikecurtis force-pushed the spike/remove-v1-tailnet branch from a5b7eac to f785a08 Compare September 11, 2024 12:59
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the test rewriting 👍

Copy link
Contributor Author

spikecurtis commented Sep 12, 2024

Merge activity

  • Sep 11, 11:40 PM EDT: @spikecurtis started a stack merge that includes this pull request via Graphite.
  • Sep 11, 11:42 PM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 11, 11:56 PM EDT: @spikecurtis merged this pull request with Graphite.

@spikecurtis spikecurtis changed the base branch from spike/legacy-agent-ip to graphite-base/14641 September 12, 2024 03:40
@spikecurtis spikecurtis changed the base branch from graphite-base/14641 to main September 12, 2024 03:40
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis force-pushed the spike/remove-v1-tailnet branch from f785a08 to 5560316 Compare September 12, 2024 03:42
@spikecurtis spikecurtis merged commit d6154c4 into main Sep 12, 2024
28 of 30 checks passed
@spikecurtis spikecurtis deleted the spike/remove-v1-tailnet branch September 12, 2024 03:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants