-
Notifications
You must be signed in to change notification settings - Fork 937
chore: remove tailnet v1 API support #14641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
dc5927c
to
e95c7bd
Compare
d9c89d3
to
2f00bd9
Compare
e95c7bd
to
4f41732
Compare
44596a9
to
2d609da
Compare
4f41732
to
bc16937
Compare
2d609da
to
64abeb7
Compare
@@ -683,7 +592,13 @@ func TestPGCoordinator_Unhealthy(t *testing.T) { | |||
logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug) | |||
|
|||
calls := make(chan struct{}) | |||
// first call succeeds, so that our Agent will successfully connect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously, we started a pipe connection and used the v1 API over it. This eventually calls Coordinate()
, but starting the pipe didn't block on Coordinate()
returning.
With the v2 API, we synchronously call Coordinate()
from the main test goroutine, so we need to get an initially successful heartbeat to unblock the Coordinate()
call or this test would deadlock.
64abeb7
to
a5b7eac
Compare
bc16937
to
46730d8
Compare
a5b7eac
to
f785a08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the test rewriting 👍
Merge activity
|
f785a08
to
5560316
Compare
Drops support for v1 of the tailnet API, which was the original coordination protocol where we only sent node updates, never marked them lost or disconnected.
v2 of the tailnet API went GA for CLI clients in Coder 2.8.0, so clients older than that would stop working.