fix: improve provisioner details layout and show count line #14749
Conversation
aslilac
commented
Sep 20, 2024
aslilac
commented
- Make the provisioner tiles more responsive to page width
- Show the number of groups and provisioners at the top of the page
- Better tags handling for PSK groups
| interface ProvisionerGroupProps { | ||
| readonly buildInfo?: BuildInfoResponse; | ||
| readonly keyName?: string; | ||
| readonly keyName: string; | ||
| readonly keyTags: Record<string, string>; | ||
| readonly type: ProvisionerGroupType; | ||
| readonly provisioners: readonly ProvisionerDaemon[]; | ||
| } |
There was a problem hiding this comment.
Is there a reason why we haven't been using the Readonly utility type more? I can't help but feel like this is a little less typing for just as much type-safety. Plus, I don't think any of our code will ever need to take advantage of interface merging
type ProvisionerGroupProps = Readonly<{
buildInfo?: BuildInfoResponse;
keyName: string;
keyTags: Readonly<Record<string, string>>;
type: ProvisionerGroupType;
provisioners: readonly ProvisionerDaemon[];
}>I know our entire API types file uses interfaces, but I'm a little fussed about that, since it's all auto-generated
There was a problem hiding this comment.
yeah, I've just been trying something 🤷♀️ idek if we get any benefit out of it when we immediately destructure the props off of the object in the component
site/src/pages/ManagementSettingsPage/OrganizationProvisionersPageView.stories.tsx
Outdated
Show resolved
Hide resolved
何？ In Romaji it should be "Jaiden". I guess it should probably be "Je" but it is definitely not "Jyeden". 🤔 |
|
@aslilac Yeah, sorry – the "jye" mora doesn't exist in Japanese. I wrote it like that because it's close to the English words "rye" and "dye" |
|
ahh I get what you meant now |
