fix: Resolve symlinks being written with size 0 in tar #1488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution found here: https://stackoverflow.com/questions/38454850/getting-write-too-long-error-when-trying-to-create-tar-gz-file-from-file-and-d Symlink's were being written with a size of 0, which surfaced an error for write too long.
coadler
reviewed
May 16, 2022
Comment on lines
+28
to
+35
| var link string | ||
| if fileInfo.Mode()&os.ModeSymlink == os.ModeSymlink { | ||
| link, err = os.Readlink(file) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
| header, err := tar.FileInfoHeader(fileInfo, link) |
There was a problem hiding this comment.
This is a bit confusing. It seems like this only works for symlinks, since we're no longer using the file var if it's not.
There was a problem hiding this comment.
The second arg is actually only a link. It was implemented incorrectly beforehand.
There was a problem hiding this comment.
So it should be empty if the file isn't a symlink?
coadler
approved these changes
May 16, 2022
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
Solution found here: https://stackoverflow.com/questions/38454850/getting-write-too-long-error-when-trying-to-create-tar-gz-file-from-file-and-d Symlink's were being written with a size of 0, which surfaced an error for write too long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution found here:
https://stackoverflow.com/questions/38454850/getting-write-too-long-error-when-trying-to-create-tar-gz-file-from-file-and-d
Symlink's were being written with a size of 0, which surfaced an error
for write too long.