feat: implement feature to support template version while creating workspace using cli #14880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creating workspace using cli
cdr-bot
bot
added
the
community
joobisb
changed the title
Emyrk
approved these changes
Oct 1, 2024
Comment on lines
+207
to
+211
| version, err := client.TemplateVersionByName(inv.Context(), template.ID, templateVersion) | ||
| if err != nil { | ||
| return xerrors.Errorf("get template version by name: %w", err) | ||
| } | ||
| templateVersionID = version.ID |
There was a problem hiding this comment.
This unfortunately does not accept the template version uuid. It would be better if the name or uuid worked.
We should fix this in the route handler imo: https://github.com/coder/coder/blob/main/coderd/templateversions.go#L885-L885
Not needed in this PR.
Emyrk
reviewed
Oct 3, 2024
Comment on lines
+146
to
+148
| version2 := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, completeWithAgent(), func(ctvr *codersdk.CreateTemplateVersionRequest) { | ||
| ctvr.TemplateID = template.ID | ||
| }) |
There was a problem hiding this comment.
Add coderdtest.AwaitTemplateVersionJobCompleted(t, client, version2.ID) after creating the version. Otherwise we get a race condition in some tests.
Suggested change
| version2 := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, completeWithAgent(), func(ctvr *codersdk.CreateTemplateVersionRequest) { | |
| ctvr.TemplateID = template.ID | |
| }) | |
| version2 := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, completeWithAgent(), func(ctvr *codersdk.CreateTemplateVersionRequest) { | |
| ctvr.TemplateID = template.ID | |
| }) | |
| coderdtest.AwaitTemplateVersionJobCompleted(t, client, version2.ID) |
There was a problem hiding this comment.
got it, I've updated the test
Emyrk
requested changes
Oct 3, 2024
Emyrk
approved these changes
Oct 3, 2024
@Emyrk the tests are passing, can we merge this ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #14860