fix: Allow fetching of non-personal workspaces #1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBAC should cover this anyways!
coadler
approved these changes
May 16, 2022
| @@ -92,31 +92,6 @@ func TestWorkspaceParam(t *testing.T) { | |||
| require.Equal(t, http.StatusNotFound, res.StatusCode) | |||
| }) | |||
|
|
|||
| t.Run("NonPersonal", func(t *testing.T) { | |||
There was a problem hiding this comment.
Do we have any tests for the workspace RBAC already?
There was a problem hiding this comment.
I think all of these endpoints need a thorough comb-over already, so the answer is no, but that's also the status quo.
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
RBAC should cover this anyways!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RBAC should cover this anyways!