Skip to content

chore: move contributor list to contributors.md #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2022
Merged

chore: move contributor list to contributors.md #1496

merged 3 commits into from
May 23, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJain AbhineetJain commented May 16, 2022 •
edited
Loading

Moves the list of contributors from README.md to CONTRIBUTORS.md

Subtasks:

  • Move the contributors list to a new file.
  • Add own name to contributors.
  • Link the new file in README.

Fixes #1416.

@AbhineetJain AbhineetJain requested a review from Emyrk May 16, 2022 22:40
@AbhineetJain AbhineetJain marked this pull request as ready for review May 16, 2022 22:49
Emyrk
Emyrk approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get something in for this to start. We will need it when we open source for license reasons probably. Keeping track of public contributors is something you need to do if you ever change the license right?

@AbhineetJain AbhineetJain enabled auto-merge (squash) May 23, 2022 18:59
@ammario
Copy link
Member

ammario commented May 23, 2022

Let's get something in for this to start. We will need it when we open source for license reasons probably. Keeping track of public contributors is something you need to do if you ever change the license right?

The list of contributors can always be generated from the git log, so I don't think this helps with that.

@AbhineetJain AbhineetJain merged commit fc46818 into main May 23, 2022
@AbhineetJain AbhineetJain deleted the 1416-canonicalize-contributor-list branch May 23, 2022 19:09
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@AbhineetJain @kylecarbs
chore: move contributor list to contributors.md (#1496)
f4084d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@ammario ammario ammario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canonicalize contributor list
3 participants
@AbhineetJain @ammario @Emyrk