{
  "_version": "1.1",
  "msg_id": "00000000-0000-0000-0000-000000000000",
  "payload": {
    "_version": "1.1",
    "notification_name": "Workspace Autobuild Failed",
    "notification_template_id": "00000000-0000-0000-0000-000000000000",
    "user_id": "00000000-0000-0000-0000-000000000000",

Ok, I know why you did this but I'm wondering if there is a way to keep stable uuids written to the golden file 🤔. It could help find out why some labels change, and prevent bugs in the future.

PS. If this is difficult->impossible, it can be postponed for later (add FIXME label).

keep stable uuids written to the golden file

What does stable mean in this context?

I mean, we could replace dynamic UUIDs with some const/known values rather than zeros. For instance:

user_id -> ceb6824e-7fe1-4000-aad9-b80bb141560a

from your comment below I infer that stable means constant and applies to the notification_template_id

ACK. Thanks

I didn't know that we could render two content-types. Curious, if we can store golden results in separate files?

Curious, if we can store golden results in separate files?

The premise that I adopted for this PR was one of integration testing. This output is meant to represent exactly what would have been sent to the customer. I did not make them render in the same file. This is how it has been. This is what we currently send to customers.

To separate them would, in my opinion, introduce artificial opportunity for drift from actual behaviour. These tests are most reliable if they not only mimick, but actually dogfood the actual system's behaviour.

If you'd like me to change it to be multiple files, I would be happy to. Would you mind helping me understand the benefit though?

Ok! If there are no benefits, then let's leave them as is. Maybe replace .html.golden with .smtp.golden as this is not just HTML file, but also Plaintext and headers.

Would you mind helping me understand the benefit though?
My original intention was keep HTML in .html.golden files, and Plaintext in .txt.golden

One more comment:

Can we keep notification_template_id as is, and not zero it? These values are const/stable.