Skip to content

chore: use system context for fetching template information #15205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Oct 23, 2024

The authz check is Update() on the original template. This is not ideal, but it follows the existing behavior. We are implicitly granting this read access since template admins need to be able to see what users/groups exist to assign.

The authz check is Update() on the original template.
This is not ideal, but it follows the existing behavior.
@Emyrk Emyrk marked this pull request as ready for review October 23, 2024 19:27
@Emyrk Emyrk requested a review from johnstcn October 23, 2024 19:28
@Emyrk Emyrk merged commit 163631e into main Oct 23, 2024
33 checks passed
@Emyrk Emyrk deleted the stevenmasley/template_admin branch October 23, 2024 22:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants