chore(cli): drop 'notification' prefix for configuring email auth #15270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SasSwart
reviewed
Oct 29, 2024
mafredri
approved these changes
Oct 29, 2024
| hello: localhost | ||
| # Force a TLS connection to the configured SMTP smarthost. | ||
| # (default: false, type: bool) | ||
| # (default: <unset>, type: bool) |
There was a problem hiding this comment.
We should probably start adding the deprecation notice to these comments at some point 🤔
| Description: "The sender's address to use.", | ||
| Flag: "email-from", | ||
| Env: "CODER_EMAIL_FROM", | ||
| Value: &c.Notifications.SMTP.From, |
There was a problem hiding this comment.
Why are we keeping .Notifications here? Rename to email?
There was a problem hiding this comment.
I kept .Notifications for now because separating out SMTP from it would be a larger refactor and at the moment we only use SMTP for notifications so didn't think it warranted being put into this PR.
There was a problem hiding this comment.
Alright, fair enough 👍🏻. Not a pressing issue but worth doing at some point to match the configuration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14644