feat: Single query for all workspaces with optional filter #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
May 17, 2022
Comment on lines
+150
to
+157
| for k, v := range assertRoute { | ||
| noTrailSlash := strings.TrimRight(k, "/") | ||
| if _, ok := assertRoute[noTrailSlash]; ok && noTrailSlash != k { | ||
| t.Errorf("route %q & %q is declared twice", noTrailSlash, k) | ||
| t.FailNow() | ||
| } | ||
| assertRoute[noTrailSlash] = v | ||
| } |
There was a problem hiding this comment.
Routes were being duplicated with a trailing slash. Just catching dev errors.
kylecarbs
approved these changes
May 18, 2022
| @@ -131,3 +131,41 @@ func (c *Client) UpdateWorkspaceAutostop(ctx context.Context, id uuid.UUID, req | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| type WorkspaceFilter struct { | |||
| OrganizationID uuid.UUID | |||
There was a problem hiding this comment.
Should we make OrganizationID be Organization, similar to Owner? Then the organization's name could be used, or its ID.
There was a problem hiding this comment.
It would be the first time we use OrganizationName in the api right? We should probably make a PR to do this everywhere if we decide for it
There was a problem hiding this comment.
I suppose we technically could make organization an ID or name, just like users.
There was a problem hiding this comment.
Yea, we just have to do it across more endpoints imo. Should be another PR to do this like the users PR I did
greyscaled
approved these changes
May 18, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* feat: Add single query for all workspaces using a filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters
Future work