-
Notifications
You must be signed in to change notification settings - Fork 934
chore: refactor ServerTailnet to use tailnet.Controllers #15408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2024
c6c3f05
to
e3f80df
Compare
cb664c3
to
8993828
Compare
e3f80df
to
791e183
Compare
8993828
to
ed2ba52
Compare
ethanndickson
approved these changes
Nov 7, 2024
791e183
to
c79d83d
Compare
ed2ba52
to
d9b0988
Compare
c79d83d
to
e6e3c8f
Compare
d9b0988
to
b8062ab
Compare
bf47e04
to
abd4edd
Compare
b8062ab
to
845efd2
Compare
845efd2
to
b8ed4ea
Compare
abd4edd
to
718722a
Compare
b8ed4ea
to
2603e6d
Compare
2603e6d
to
778457b
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore of #14729
Refactors the
ServerTailnet
to usetailnet.Controller
so that we reuse logic around reconnection and handling control messages, instead of reimplementing. This unifies our "client" use of the tailscale API across CLI, coderd, and wsproxy.