Skip to content

chore: increase autostop requirement leeway to two hours #15445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Nov 8, 2024

Closes #12612

The problem in the linked issue was caused due to a mismatch of when the Web UI tooltip shows up (2 hours before an autostop requirement) and the leeway in the autostop_requirement algorithm (workspace builds must be 1 hour before an autostop requirement to skip them).

Now, restarting your workspace whilst the tooltip is showing will skip the upcoming autostop requirement.

This also could have been fixed by only showing the tooltip one hour before the autostop requirement, but it looks like 1 hour was chosen arbitrarily, and it doesn't hurt to give users more time to skip the autostop.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson marked this pull request as ready for review November 8, 2024 09:18
@ethanndickson ethanndickson merged commit a5d1977 into main Nov 12, 2024
27 checks passed
@ethanndickson ethanndickson deleted the ethan/autostop-leeway branch November 12, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restarting workspace ahead of quiet hours does not prevent Autostop requirement
2 participants