feat: don't return 200 for deleted workspaces #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
May 18, 2022
coderd/workspaces.go
Outdated
| // `deleted` field on the workspace otherwise you will get a 410 Gone. | ||
| var ( | ||
| deletedStr = r.URL.Query().Get("deleted") | ||
| deleted = false |
There was a problem hiding this comment.
nit: semantics: suggest renaming this to showDeleted
There was a problem hiding this comment.
In the query parameter or just this variable name? I'm not a fan of capital letters in query params (or any URL stuff)
There was a problem hiding this comment.
Sorry, I was mainly thinking about the variable name, deleted=1 as a query parameter is fairly standard imo.
johnstcn
reviewed
May 18, 2022
johnstcn
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
deletedquery parameter which defaults tofalseon the get workspace by ID endpoint. The query param must matchworkspace.Deletedotherwise the request will fail.Resolves #832