Skip to content

fix(site): avoid constructing invalid apps url #15711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(site): avoid constructing invalid apps url #15711

merged 1 commit into from
Dec 2, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Dec 2, 2024 •
edited
Loading

In Firefox, parsing a URL containing a * returns an error:

new URL("https://*--apps.sydney.fly.dev.coder.com") 

Uncaught TypeError: URL constructor: https://*--apps.sydney.fly.dev.coder.com is not a valid URL.
    <anonymous> debugger eval code:1

In Chrome and Node, this same URL does not produce an error.

This causes a workspace dashboard with apps to fail to load on Firefox.
image

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson force-pushed the ethan/apps-firefox-url branch from 3fcf40e to e59b086 Compare December 2, 2024 08:35
@ethanndickson ethanndickson force-pushed the ethan/apps-firefox-url branch from e59b086 to bd8ec8c Compare December 2, 2024 08:36
cdr-bot[bot]
cdr-bot bot approved these changes Dec 2, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndickson ethanndickson marked this pull request as ready for review December 2, 2024 08:39
@ethanndickson ethanndickson enabled auto-merge (squash) December 2, 2024 08:40
@ethanndickson ethanndickson merged commit abb3df7 into main Dec 2, 2024
39 of 41 checks passed
@ethanndickson ethanndickson deleted the ethan/apps-firefox-url branch December 2, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ethanndickson